Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the reopen_files by using FileHandler's method: close & _open #1742

Merged
merged 1 commit into from Apr 3, 2018
Merged

Optimize the reopen_files by using FileHandler's method: close & _open #1742

merged 1 commit into from Apr 3, 2018

Conversation

ysymi
Copy link
Contributor

@ysymi ysymi commented Apr 3, 2018 •
edited

Fix #1739

Reopen log files by using FileHandler's method, so that gunicorn can be compatible with different handler.

I tested this change on my handler, gunicorn reopen files as expected. Also tested by tox, and succeeded in py26, py27, py35 on my server .

tilgovi
tilgovi approved these changes Apr 3, 2018
View reviewed changes
Copy link
Collaborator

@tilgovi tilgovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tilgovi tilgovi merged commit 54e3b05 into benoitc:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilgovi tilgovi tilgovi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ysymi @tilgovi